[openib-general] Re: [PATCH] 1/2 separate locking for send and receive q in mthca

Michael S. Tsirkin mst at mellanox.co.il
Thu Feb 3 13:39:57 PST 2005


Quoting r. Roland Dreier <roland at topspin.com>:
> Subject: Re: [PATCH] 1/2 separate locking for send and receive q in mthca
> 
>     Michael> Ok.  Its quite straight-forward - move lock to the wq
>     Michael> structure, and use it from there.
> 
> Right, but I'm not sure if that's the best way to go... there may be
> better ways to lay out the structure, and we may want to mark things
> with __cacheline_aligned_in_smp to make sure we get what we want.
> 
>  - R.
> 

Aha. Good.
Another thing maybe worth it looking into was the idea
to use atomics instead of the lock for cq poll ... we'll see.

-- 
MST - Michael S. Tsirkin



More information about the general mailing list