[openib-general] Re: [PATCH] remove unused code from SDP.

[Michael S. Tsirkin]

Quoting r. Libor Michalek <libor at topspin.com>:
> Subject: [PATCH] remove unused code from SDP.
> 
> 
>   There's code in SDP which is never used, mostly helper functions that
> at the time looked like they might be useful, but never got used.
> 
> -Libor
> 
> Signed-off-by: Libor Michalek <libor at topspin.com>
> 
> Index: sdp_link.c
> ===================================================================
> --- sdp_link.c	(revision 1831)
> +++ sdp_link.c	(working copy)
> @@ -321,7 +321,7 @@
>  /*
>   * _sdp_link_path_rec_get - resolve GIDs to a path record
>   */
> -int _sdp_link_path_rec_get(struct sdp_path_info *info)
> +static int _sdp_link_path_rec_get(struct sdp_path_info *info)
>  {
>  	int result;
>  

Good stuff. 
One comment though - one can give short names to static functions:
since they are local to file they wont conflict with anything other.
So - why prepend an "_" to the name?

-- 
MST - Michael S. Tsirkin