[openib-general] [PATCH] make device_cap_flags unsigned

Roland Dreier roland at topspin.com
Tue Feb 22 08:52:25 PST 2005


    Michael> Since device_cap_flags is a set of ORed values, make the
    Michael> result unsigned. Also to be in line with other flags.

This doesn't seem to make any practical difference, since the largest
device cap flag is 1<<15, and even if it were 1<<31 we never do any
non-bitwise arithmetic so signedness doesn't matter.  If we're going
to change the type at all, I would suggest changing it to "enum
ib_device_cap_flags," which at least is somewhat self-documenting.

 - R.



More information about the general mailing list