[openib-general] Re: Re: [PATCH][SDP][14/22] Whitespace cleanup in sdp_proto.h
Michael S. Tsirkin
mst at mellanox.co.il
Tue Feb 22 12:32:05 PST 2005
Quoting r. Libor Michalek <libor at topspin.com>:
> Subject: Re: Re: [PATCH][SDP][14/22] Whitespace cleanup in sdp_proto.h
> On Sun, Feb 20, 2005 at 10:07:43AM -0800, Tom Duffy wrote:
> > On Sun, 2005-02-20 at 02:05 +0200, Michael S. Tsirkin wrote:
> > >
> > > I think we also should replace __inline__ with inline everywhere.
> > >
> > > Also, I think the convention is to add __ before inline functions
> > > if they are an implementation detail and shouldnt be called
> > > directly.
> > > That does not seem to be the case for __sdp_inet_write_space, or for
> > > other stuff in sdp_proto.h, so I think these functions shall have
> > > proper names starting with an alphanumeric.
> > Yeah, I also don't like the convention of using _ in front of static
> > functions. Those can be updated in the next set of patches ;)
> I agree, all those changes should be made to the code. There's a
> number of coding conventions which need to be changed to a saner
Good. By the way, do you plan to keep the convention of writing
0 == foo?
I personally dislike it (and Linux expressed the same santiment at some
point), this practice unnecessary with gcc
which warns if you write if (foo = 0) accidentally, and
kernel code itself never does it, but some in-kernel drivers
do it ... its easy to fix more or less automatically.
MST - Michael S. Tsirkin
More information about the general