[openib-general] CHECK_NULL

Roland Dreier roland at topspin.com
Wed Feb 23 13:49:15 PST 2005


There's no need for a return statement at the end of a void function
as in code like:

 > -static int _sdp_iocb_q_cancel_read_pending(struct sdp_opt *conn, ssize_t error)
 > +static void _sdp_iocb_q_cancel_read_pending(struct sdp_opt *conn,
 > +					    ssize_t error)
 >  {
 > -	return sdp_iocb_q_cancel(&conn->r_pend, SDP_IOCB_F_ALL,
 > -					error);
 > +	sdp_iocb_q_cancel(&conn->r_pend, SDP_IOCB_F_ALL, error);
 > +	return;
 >  } /* _sdp_iocb_q_cancel_read_pending */

 - R.



More information about the general mailing list