[openib-general] [PATCHv2][SDP][17/22] Remove use of leading underscores in static names in sdp_queue.h

Tom Duffy tduffy at sun.com
Mon Feb 28 15:42:28 PST 2005


On Mon, 2005-02-28 at 15:24 -0800, Libor Michalek wrote:
> > -#define sdp_desc_q_size(x)   __sdp_desc_q_size(x)
> > -#define sdp_desc_q_member(x) __sdp_desc_q_member(x)
> > +#define sdp_desc_q_size(x)   sdp_desc_q_size(x)
> > +#define sdp_desc_q_member(x) sdp_desc_q_member(x)
> 
>   In this case wouldn't you just get rid of the two #defines? 

Duh.  Yeah.

Signed-off-by: Tom Duffy <tduffy at sun.com>

Index: drivers/infiniband/ulp/sdp/sdp_queue.h
===================================================================
--- drivers/infiniband/ulp/sdp/sdp_queue.h	(revision 1930)
+++ drivers/infiniband/ulp/sdp/sdp_queue.h	(working copy)
@@ -71,22 +71,19 @@ struct sdpc_desc_q {
  */
 
 /*
- * __sdp_desc_q_size - return the number of elements in the table
+ * sdp_desc_q_size - return the number of elements in the table
  */
-static inline int __sdp_desc_q_size(struct sdpc_desc_q *table)
+static inline int sdp_desc_q_size(struct sdpc_desc_q *table)
 {
 	return table->size;
 }
 
 /*
- * __sdp_desc_q_member - return non-zero if element is in a table
+ * sdp_desc_q_member - return non-zero if element is in a table
  */
-static inline int __sdp_desc_q_member(struct sdpc_desc *element)
+static inline int sdp_desc_q_member(struct sdpc_desc *element)
 {
 	return (element->table ? 1 : 0);
 }
 
-#define sdp_desc_q_size(x)   __sdp_desc_q_size(x)
-#define sdp_desc_q_member(x) __sdp_desc_q_member(x)
-
 #endif /* _SDP_QUEUE_H */




More information about the general mailing list