[openib-general] [PATCH] Convert Infiniband MAD driver to compat/unlocked_ioctl

Michael S. Tsirkin mst at mellanox.co.il
Tue Jan 18 03:20:47 PST 2005


Quoting r. Andi Kleen (ak at muc.de) "Re: [openib-general] [PATCH] Convert Infiniband MAD driver to compat/unlocked_ioctl":
> On Tue, Jan 18, 2005 at 11:28:53AM +0200, Michael S. Tsirkin wrote:
> > 
> > Quoting r. Andi Kleen (ak at muc.de) "[openib-general] [PATCH] Convert Infiniband MAD driver to compat/unlocked_ioctl":
> > > 
> > > Convert MAD driver to compat/unlocked_ioctl. Streamlines the code a bit.
> > > 
> > > Signed-off-by: Andi Kleen <ak at muc.de>
> > 
> > Good, but this would require that people run at least 2.6.11-rc1-bk5
> > which sounds a bit steep. Maybe check the HAVE_COMPAT_IOCTL macro for now?
> 
> Nah, for in tree code we avoid using such macros. You're merged now, you
> have to follow the rules ;-)
> 
> -Andi

I know.

But we are working off the common subversion tree here, so
its best to accomodate people. Our rule was to support
the last release from kernels.org, its not like we are talking
2.4.18 here.

Look, this is actually up to Roland.
In my humble option, either this checkin should happen after 2.6.11
is out, or add the ifdef and a comment so that when Roland sends the patch
upstream, he'll remember to strip them off.

MST



More information about the general mailing list