[openib-general] [PATCH] (fixed) cqe lookup speedup

Roland Dreier roland at topspin.com
Wed Jan 26 15:46:30 PST 2005


    Grant> this could be one line: struct mthca_cqe *cqe = get_cqe(cq, i);

Yes, makes sense as a cleanup.

    Grant> This code chunk is "dead" code. It starts with "if (0)".
    Grant> Can it just be deleted?

It's actually debugging code -- it can be enabled easily by changing
to if (1).

    Grant> BTW, I dislike use of "is_send" to branch the code path
    Grant> several times later instead of just having two different
    Grant> code paths that call the same in-line functions. Interested
    Grant> in a patch to change this?

Let me merge what I have pending and then you can hack away...

 - R.



More information about the general mailing list