[openib-general] Re: [PATCH 3/27] Add MAD helper functions

[Hal Rosenstock]

On Mon, 2005-07-11 at 12:29, Alexey Dobriyan wrote:
> On Monday 11 July 2005 19:30, Hal Rosenstock wrote:
> > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote:
> > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote:
> > > > Add new helper routines for allocating MADs for sending and formatting
> > > > a send WR.
> > > 
> > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c
> > > > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c
> > > 				   ^^^^^^^^^^^
> > > Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...].
> > 
> > Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ?
> 
> I'd wait for comments and then resubmit clean series which can be applied
> with patch -p1.
> 
> > > > +struct ib_mad_send_buf * ib_create_send_mad(struct ib_mad_agent *mad_agent,
> > > > +					    u32 remote_qpn, u16 pkey_index,
> > > > +					    struct ib_ah *ah,
> > > > +					    int hdr_len, int data_len,
> > > > +					    int gfp_mask)
> > > 
> > > unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings
> > > is not a reason to add more.
> > 
> > I'll fix this in a subsequent patch. Is that OK ?
> 
> If Andrew will fix patches locally, OK.

I will work this into the resubmitted patches.

-- Hal