[openib-general] Re: [PATCHv2} ucm: Only print messages when debug level set

Hal Rosenstock halr at voltaire.com
Wed Jul 13 16:31:31 PDT 2005


On Wed, 2005-07-13 at 16:29, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > @@ -56,6 +61,10 @@ enum {
> >  
> >  #define IB_UCM_DEV MKDEV(IB_UCM_MAJOR, IB_UCM_MINOR)
> >  
> > +#define ucm_dbg(format, arg...)                 \
> > +	if (ucm_debug_level > 0)        \
> > +		printk(KERN_DEBUG format, ## arg)
> > +
> 
> What happened to whitespace here?

Not sure. Should be fixed in next version of patch.

> Also, may it be a good idea for ucm_dbg to add the UCM: prefix automatically?

OK.

-- Hal




More information about the general mailing list