[openib-general] Re: [PATCH] mthca: report board id in sysfs

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rolandd at cisco.com>:
> Subject: Re: [PATCH] mthca: report board id in sysfs
> 
>     Michael> Since topspin cards have a distinct vendor id, its
>     Michael> possible they dont need the board id at all.
>     Michael> 
>     Michael> What'd you like to do?  - Report empty board id (thats
>     Michael> what current code does). User can follow the device link
>     Michael> and use vendor id to figure out its a topspin card.  -
>     Michael> Check topspin vendor id and report some hard-coded string
>     Michael> in board_id.  - Check topspin vendor id and report some
>     Michael> other field from the vpd.
> 
>     Michael> Any ideas yet?  I'd like to add that what this patch does
>     Michael> is basically get parity with the VAPI vstat
>     Michael> functionality.
> 
> Sorry, I've been on vacation...
> 
> Anyway, unfortunately most Topspin/Cisco cards don't have a distinct
> vendor ID -- they ship with the Mellanox vendor ID.
> 
> The only difference is our VSD format.  We do have a board ID in the
> VSD, but it's at a different offset and so QUERY_ADAPTER doesn't
> return it to the driver, as far as I know.
> 
>  - R.
> 

AFAIK, all of VSD gets reported back to the driver.
What do you say about merging my patch, and then either

- report empty board id as vapi does

- add support for topspin cards along the following lines:
  if board_id is empty, get it at another offset.

  I could code that up myself but I dont have any topspin hardware.

-- 
MST