[openib-general] [PATCH] AT: cleanup some sparse warnings

Sean Hefty mshefty at ichips.intel.com
Thu Jul 28 13:59:48 PDT 2005


Tom Duffy wrote:
> This patch cleans up a few sparse warnings in AT.
>  
> Index: linux-2.6.13-rc3-openib/drivers/infiniband/core/at_priv.h
>  
>  #define IB_ATS_SERVICE_NAME             "DAPL Address Translation Service"
> -#define IB_ATS_SERVICE_ID               cpu_to_be64(0x10000ce100415453)
> -#define IB_ATS_LAST_SERVICE_ID          cpu_to_be64(0x10000ce1ff415453)
> +#define IB_ATS_SERVICE_ID               cpu_to_be64(0x10000ce100415453ULL)
> +#define IB_ATS_LAST_SERVICE_ID          cpu_to_be64(0x10000ce1ff415453ULL)
>  #define IB_ATS_OPENIB_MAGIC_KEY         cpu_to_be16(IB_OPENIB_OUI & 0xffff)

I usually use __constant_cpu_to_be* to byte swap constants.  (I think I did 
it to allow the use of the #define in case statements.)

- Sean



More information about the general mailing list