[openib-general] [PATCH] ib_ucm: remove devfs usage

Bill Jordan bjordan at sbc2.infiniconsys.com
Wed Jun 1 14:52:47 PDT 2005


Libor,

Here is a patch to remove the devfs usage from ib_ucm.

The udev support already exists, but requires a
rule entry of KERNEL="ucm", NAME="infiniband/%k".
Is there an appropriate place that the udev rules
should be documented?

Signed-off-by: Bill Jordan <bjordan at silverstorm.com>

Index: ucm.c
===================================================================
--- ucm.c	(revision 2519)
+++ ucm.c	(working copy)
@@ -40,7 +40,6 @@
 #include <linux/file.h>
 #include <linux/mount.h>
 #include <linux/cdev.h>
-#include <linux/devfs_fs_kernel.h>
 
 #include <asm/uaccess.h>
 
@@ -1376,10 +1375,6 @@ static int __init ib_ucm_init(void)
 				NULL,
 				"ucm");
 	
-	devfs_mk_cdev(IB_UCM_DEV,
-		      S_IFCHR|S_IRUGO|S_IWUGO,
-		      "infiniband/ucm");
-
 	idr_init(&ctx_id_table);
 	init_MUTEX(&ctx_id_mutex);
 
@@ -1394,7 +1389,6 @@ err_chr:
 
 static void __exit ib_ucm_cleanup(void)
 {
-	devfs_remove("infiniband/ucm");
 	class_simple_device_remove(IB_UCM_DEV);
 	class_simple_destroy(ib_ucm_class);
 	cdev_del(&ib_ucm_cdev);



More information about the general mailing list