[openib-general] [PATCH] kDAPL: remove use of HANDLEs

Christoph Hellwig hch at lst.de
Tue Jun 7 17:25:53 PDT 2005


On Tue, Jun 07, 2005 at 02:29:21PM -0700, Tom Duffy wrote:
> On Tue, 2005-06-07 at 17:16 -0400, James Lentini wrote:
> > Any objections to removing the NULL pointer checks of API parameters?
> 
> Fine by me.  Although BUG_ON() may be more appropriate.

a BUG_ON doesn're provide any more info than a NULL-pointer dereference.

> How about after applying my patch?

absolutely.  let's get your patch in ASAP, it's a huge improvement.




More information about the general mailing list