[openib-general] Re: [PATCH][SDP] state transition simplification.

Michael S. Tsirkin mst at mellanox.co.il
Wed Jun 8 13:39:16 PDT 2005


Quoting r. Libor Michalek <libor at topspin.com>:
> Subject: [PATCH][SDP] state transition simplification.
> 
> 
>   This patch simplifies the state transitions for connection management
> within SDP. Previously the connection state was maintained using two
> variables 'istate' and 'state' with a combined total of 34 different
> values. The patch merges the two into a single variable 'state' and 
> removes redundancy for a total of 16 state values. Also the file
> sdp_wall.c is removed who's original purpose was to keep the two state
> variables synchronized.
> 
>   The simplification also paves the way for the next step, which is to
> use the CM event for transitions instead of the current incorrest use
> of CM state.
> 
>   The CQ event pending flags were moved from the connection flags field
> to a new field in the event lock.
> 
>   Finally, I needed to ifdef out one of the send_dreq calls, because
> I was seeing a problem when two DREQs would cross in flight and both
> sides responded with a DREP.
> 
>   13 files changed, 404 insertions(+), 1045 deletions(-)
> 
> -Libor

Works fine for me so far.

-- 
MST



More information about the general mailing list