[openib-general] [PATCHv4] kdapl: remove use of HANDLE's (vs. r2572)

Tom Duffy tduffy at sun.com
Wed Jun 8 13:52:47 PDT 2005


On Wed, 2005-06-08 at 22:41 +0200, Bernhard Fischer wrote:
> On Wed, Jun 08, 2005 at 01:19:41PM -0700, Tom Duffy wrote:
> >On Wed, 2005-06-08 at 21:48 +0200, Bernhard Fischer wrote:
> 
> >> 'if (NULL != this)' and 'if (0 != that)' occurances, too? I personally
> >> would appreciate it, since these variants are harder to read for me.
> >
> >What do you want to see instead?
> >
> >if (this) {
> >	/* do stuff */
> >}
> 
> yes, this.

I think James would take these types of patches.

In any event, going through the code with fine toothed comb will happen
after all the major upheavals, I think.  *I* want to fix all the major
architectural issues that are holding up acceptance before nit-picking.

If I have the time or inclination, I will clean up these things.

-tduffy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050608/610ded1f/attachment.sig>


More information about the general mailing list