[openib-general] [PATCHv4] kdapl: remove use of HANDLE's (vs. r2572)

James Lentini jlentini at netapp.com
Wed Jun 8 14:55:02 PDT 2005



On Wed, 8 Jun 2005, Tom Duffy wrote:

> On Wed, 2005-06-08 at 22:41 +0200, Bernhard Fischer wrote:
>> On Wed, Jun 08, 2005 at 01:19:41PM -0700, Tom Duffy wrote:
>>> On Wed, 2005-06-08 at 21:48 +0200, Bernhard Fischer wrote:
>>
>>>> 'if (NULL != this)' and 'if (0 != that)' occurances, too? I personally
>>>> would appreciate it, since these variants are harder to read for me.
>>>
>>> What do you want to see instead?
>>>
>>> if (this) {
>>> 	/* do stuff */
>>> }
>>
>> yes, this.
>
> I think James would take these types of patches.

I would.

> In any event, going through the code with fine toothed comb will happen
> after all the major upheavals, I think.  *I* want to fix all the major
> architectural issues that are holding up acceptance before nit-picking.
>
> If I have the time or inclination, I will clean up these things.
>
> -tduffy
>



More information about the general mailing list