[openib-general] [mthca] debug strings

Roland Dreier roland at topspin.com
Mon Jun 13 10:34:17 PDT 2005


Thanks, I applied most of these changes.

    Bernhard> In mthca_map_eq_regs(), i take it that it is of no
    Bernhard> interrest to know who of
    Bernhard> "..dev->fw.arbel.eq_"arm_base|eq_set_ci_base") + "(0|4)
    Bernhard> did trigger? Memfree vs. not would be obvious from
    Bernhard> previous msgs.  Same in mthca_tune_pci for cap messages
    Bernhard> (which don't fit into width=80 terminals)

I'm not sure I understood what you wrote here, but the messages in
mthca_map_eq_regs() were indeed wrong -- I sloppily cut and pasted and
didn't update the error messages.  However I couldn't find anything
wrong with the messages in mthca_tune_pci().

    Bernhard> find_mgm(): 'if (0)\n\t\tmthca_dbg(dev, "Hash for..' 
    Bernhard> should not rely on dead code elimination but
    Bernhard> HEAVY_DEBUG. Haven't looked for other occurances of
    Bernhard> that, yet. Will you?

I'm sorry, I can't understand this paragraph.  Could you rephrase it?

Thanks,
  Roland



More information about the general mailing list