[openib-general] Re: [PATCH] kDAPL: convert the ep list to linux native

Tom Duffy tduffy at sun.com
Mon Jun 13 14:35:30 PDT 2005


On Mon, 2005-06-13 at 17:10 -0400, James Lentini wrote:
> This looks good. I've checked it in as revision 2595. 

Thanks.

> Eventually, we could move the list up into the dapl_common structure.

Gross.  I agree with Christoph.

> The one oddity is that all the objects are put on the IA list except 
> CRs which are placed on an SP. I think it would be worth reflecting 
> this in the list's member name. Instead of calling it a ia_list_entry 
> as it is now, a name like parent_list or owner_list would be more 
> appropriate.

Eventually, wouldn't we get rid of ia_list_entry?  Cause each struct has
its own list entry (name "list", which seems to be the convention), and
the IA has the heads of each list.

Your wording is a bit confusing cause you say, "all the objects are put
on the IA list".  Shouldn't that read, "each of the objects is put on
its respective list owned by the IA" or some such?

-tduffy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050613/fc7827ec/attachment.sig>


More information about the general mailing list