[openib-general] Re: [PATCH] kDAPL: convert the ep list to linux native

James Lentini jlentini at netapp.com
Tue Jun 14 08:32:39 PDT 2005



On Mon, 13 Jun 2005, Christoph Hellwig wrote:

> On Mon, Jun 13, 2005 at 05:10:31PM -0400, James Lentini wrote:
>>
>> Tom.
>>
>> This looks good. I've checked it in as revision 2595.
>>
>> Eventually, we could move the list up into the dapl_common structure.
>> The one oddity is that all the objects are put on the IA list except
>> CRs which are placed on an SP. I think it would be worth reflecting
>> this in the list's member name. Instead of calling it a ia_list_entry
>> as it is now, a name like parent_list or owner_list would be more
>> appropriate.
>
> Umm, no.  Please try to get rid of dapl_common instead of adding to it.

Can you elaborate on this? Is this a style or performance issue?



More information about the general mailing list