[openib-general] Re: [PATCH] sa_query: Add service record support

Hal Rosenstock halr at voltaire.com
Tue Jun 28 14:42:33 PDT 2005


On Tue, 2005-06-28 at 17:34, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > Subject: [PATCH] sa_query: Add service record support
> > 
> > sa_query: Add service record support
> > 
> > Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> >
> > ...
> >
> > +struct ib_sa_srvrec_query {
> > +	void (*callback)(int, struct ib_sa_service_rec *, void *);
> > +	void *context;
> > +	struct ib_sa_query sa_query;
> > +};
> > +
> 
> Can this be renamed to struct ib_sa_service_rec_query, please?
> Or does it mean something else?

Sure but ib_sa_service_query would be more in keeping.

I'll wait to see what other comments come back before posting an updated patch.

-- Hal




More information about the general mailing list