[openib-general] mr_table.max_mtt_order

Roland Dreier roland at topspin.com
Thu Mar 3 12:43:48 PST 2005


    Roland> I thought about this a little.  I think that any inline
    Roland> function forces someone reading the code to look up what
    Roland> it does, no matter how descriptive the name we come up
    Roland> with.  I think it would be better to use fls() directly.
    Roland> I'm already in the habit of using ffs() to compute log_2
    Roland> of powers of two but for some reason I never remember
    Roland> fls().

Actually, since there's already roundup_pow_of_two() in kernel.h,
let's use that.

 - R.



More information about the general mailing list