[openib-general] Re: [RFC] userspace CM/verbs QP

Roland Dreier roland at topspin.com
Tue Mar 8 12:13:03 PST 2005


    Sean> Roland, do you have a preference for exposing the
    Sean> device_list and device_sem in device.c?  I can put
    Sean> ib_get_cached_gid() directly in device.c, but that separates
    Sean> the caching functions.  I could also change cache.c to
    Sean> maintain its own device list, which encapsulates the changes
    Sean> more, but duplicates the list.

I think it makes sense to expose the list and sem to cache.c.  Of
course we should change the names so that they're less generic (ie add
an "ib_" prefix) to avoid clashes if someone builds IB support into
a monolithic kernel.

Also it probably makes sense to turn device_sem into an rwsem and use
down_read() if cache.c to allow concurrent lookups by the CM.

 - R.




More information about the general mailing list