[openib-general] [RFC] [PATCH] ping: Add IB ping server agent

Sean Hefty mshefty at ichips.intel.com
Thu Mar 17 12:55:27 PST 2005


Hal Rosenstock wrote:

> ping: Add IB ping server agent (used with ibping diagnostic tool)
{snip}
> +		ret = ib_ping_port_open(device, cur_port);
> +		if (ret) {
> +			printk(KERN_ERR PFX "Couldn't open %s port %d "
> +			       "for ping agent\n",
> +			       device->name, cur_port);
> +		}
>  	}

My preference would still be to keep this a separate module.  IMO, we 
need to improve the encapsulation of the MAD layer, not weaken it, 
possibly removing all MAD agents from mad.c.

- Sean



More information about the general mailing list