[openib-general] [kDAPL][PATCH] fix panic in server side

Hal Rosenstock halr at voltaire.com
Wed May 4 15:14:26 PDT 2005


On Wed, 2005-05-04 at 17:59, Tom Duffy wrote:
> Signed-off-by: Tom Duffy <tduffy at sun.com>
> 
> Index: dapl_openib_cm.c
> ===================================================================
> --- linux-kernel/dat-provider/dapl_openib_cm.c	(revision 2257)
> +++ linux-kernel/dat-provider/dapl_openib_cm.c	(working copy)
> @@ -227,6 +227,9 @@ int dapl_cm_passive_cb_handler(struct ib
>  {
>  	int ret = 0;
>  
> +	if (!comm_id)
> +		return -1;
> +

I also think this should be:
	if (!comm_id)
		return 0;

but I'm not sure why the CM would callback with a NULL comm_id.

Also, I wonder if the same thing could occur on the active side too.

-- Hal




More information about the general mailing list