[openib-general] [patch] misc trivia nitpicks 04

Grant Grundler iod00d at hp.com
Fri May 6 12:43:30 PDT 2005


On Fri, May 06, 2005 at 07:41:04PM +0200, Bernhard Fischer wrote:
> 02 was get_clock.h: if mhz!=m set mhz=0.0 and break so the file is
> closed proper. I haven't sent that yet.

I've fixed now too.

I've added an option for the program to print out the results in cycles.

And get_clock_khz() is silly - it should be called get_clock_mhz since
the usage is:
	double mhz = get_cpu_khz()/1000;

and all the arches I have report:
	ia64 reports "cpu MHz    : 1500.000000"
	x86  reports "cpu MHz         : 1000.814"
	parisc reports "cpu MHz         : 650.000000"

I also fixed a typo "meadian" (vs median).

I'll post a -02 version shortly at:
	http://gsyprf3.external.hp.com/openib/perftest-02.tgz


> Should i send a patch later or will MST fix this?

I'll keep pestering MST with this bit. :^)

thanks,
grant



More information about the general mailing list