[PATCH] Re: [openib-general] 0 op factor

[Libor Michalek]

On Sat, May 07, 2005 at 07:47:18PM +0200, Bernhard Fischer wrote:
> On Thu, May 05, 2005 at 05:21:22PM -0700, Libor Michalek wrote:
> >   No point other then the obvious, changing the sign of the variables
> >value. It's just a style convention that I have no problem changing.
> 
> - remove '0 operator factor' statements.
> - a bit of whitespace removal.
> - remove return at end of void functions.

  If you're removing the 'return' why not remove the blank line before
it as well.

> - remove expect from _sdp_cm_path_complete().

  When I said that the SDP_EXPECT should eventually be removed, I meant
that the functions which have their return values checked by SDP_EXPECT
should either be turned into void return functions, or something 
intelligent should be done with the return value, such as error recovery
or propogation. The functions which should be turned into void functions
are the ones which will never return anything but success.


-Libor