[openib-general] Re: [PATCH] SDP & CM: change some functions to return void

Libor Michalek libor at topspin.com
Fri May 13 11:32:58 PDT 2005


On Fri, May 13, 2005 at 09:30:32AM -0700, Sean Hefty wrote:
> Tom Duffy wrote:
> > This patch changes some functions to return void rather than an int
> > since they were always returning 0, thus making checking return values
> > rather pointless.  The patch touches both SDP and CM.
> 
> Thanks, Tom.  Since the majority of these changes affect SDP, and the 
> check-ins should be coordinated, I'll ask Libor if he can commit the CM 
> changes when he commits the SDP changes.
> 
> Libor, can you commit the CM changes when you commit the SDP changes?  :) 
> There are also some (void)ib_destroy_cm_id casts in umc.c that could lose 
> the casts with this change as well.

  OK, I applied and commited the patch. Thanks Tom.

-Libor



More information about the general mailing list