[openib-general] Re: Possible minor change to ucm.c

[Libor Michalek]

On Fri, May 20, 2005 at 10:49:40AM -0400, Hal Rosenstock wrote:
> Hi Libor,
> 
> A possible minor change to ucm.c::ib_ucm_event_handler line 440 would
> be:
> 
>         uevent->cm_id = (id == IB_UCM_CM_ID_INVALID ?
>                          cm_id : NULL);
> rather than:
>         uevent->cm_id = ((event->event == IB_CM_REQ_RECEIVED ||
>                           event->event == IB_CM_SIDR_REQ_RECEIVED ) ?
>                          cm_id : NULL);

  Why make the change, since they have the same effect? The only way
an invalid 'id' will make it that far in the code is during those
two events.

-Libor