[openib-general] Re: [openib-commits] r2426 - gen2/users/jlentini/linux-kernel/dat-provider

[Bernhard Fischer]

On Mon, May 23, 2005 at 10:32:12AM -0400, James Lentini wrote:
>
>Bernhard,
>
>Thank you for pointing these items out. Comments below:
>
>On Sat, 21 May 2005, Bernhard Fischer wrote:
>
>>On Fri, May 20, 2005 at 03:05:08PM -0700, jlentini at openib.org wrote:
>>>Author: jlentini
>>>Date: 2005-05-20 15:05:07 -0700 (Fri, 20 May 2005)
>>>New Revision: 2426

>>>-		if (DAPL_GET_CQE_OPTYPE(cqe_ptr) == OP_RECEIVE) {
>>>+		     "\t\t work_req_id %lli\n", cqe_ptr->wr_id);
>>[[:space:]] --------------^ ?
>
>Which space are you referring to? The one between \t\t and 
>work_req_id?
Yes, i ment the one between \t\t and work_req_id. I now see that those
are part of the formatting, so i retract this comment. Sorry.

>>>@@ -667,21 +657,21 @@
>>>
>>>#ifdef DAPL_DBG
>>>			/* Current gen2 mthca is not setting the opcode in 
>>>			seccesful cqe      */

s/secces/succes/g

>>>-			/* The opcode will be OP_SEND or OP_RECEIVE acording 
>>>the is_send bit  */
>>>+			/* The opcode will be IB_WC_SEND or IB_WC_RECV 
>>>acording the is_send bit  */
>>"acording" -enoparse: s/acord/accord/g
>>
>>also in:
>>gen2/branches/shaharf-ibat/src/userspace/management/osm/opensm/osm_state_mgr.c
>>gen2/branches/roland-uverbs/src/userspace/management/osm/opensm/osm_sa_mcmember_record.c
>>gen2/utils/src/linux-user/ibdm/datamodel/ibdm.i
>>gen2/utils/src/linux-user/IBMgtSim/src/ibdm.i
>>gen2/utils/src/linux-user/IBMgtSim/utils/RunSimTest
>>there: callabcks: -enoparse;
>>continue with acord:
>>gen2/users/jlentini/linux-kernel/dat-provider/dapl_evd_util.c
>>gen2/trunk/src/userspace/management/osm/opensm/osm_state_mgr.c
>
>I've fixed my error:
>
>gen2/users/jlentini/linux-kernel/dat-provider/dapl_evd_util.c

Ok, thank you.
>
>The others belong to Roland, Shahar, and Eitan.

>>>-		{
>>>-			struct dat_ep_attr ep_attr;
>>>-			struct dat_named_attr ep_state;
>>>+		(void) dapl_modify_qp_state_to_error(ep_ptr->qp_handle);
>>
>>sun will hopefuly fix all of
>>egrep -ri "(^[[:space:]]*\(void\))"
>>openib.gen2/upstream/gen2/trunk/|egrep -v "svn-(text|base)"
>>so i won't comment on that single occurance above ;)
>
>I didn't realize the convention was to not have spaces before a cast. 
>This isn't in Documentation/CodingStyle. I know I've been adding these 
>here and there. I'll fix these as I see them.

I ment that Tom Duffy and you will take care of converting a couple of
those into void functions, so the casts will no longer be needed. It's
not worth the effort to remove the space after the cast. In contrast,
personally, i find that the space makes to code easier to read.

cheers,
Bernhard