[openib-general] libehca causes segfault when not physically present..

[Roland Dreier]

    Heiko> this bug should be fixed in OpenIB trunk 3960.

It's good to see this fixed and all the other cleanups in this
checkin.  I'll have to go back to my ehca code reviewing....

However, when this code moves upstream, you'll have to make your
changes in smaller digestible chunks.  The diff between r3959 and
r3960 is rather gigantic:

 33 files changed, 945 insertions(+), 1163 deletions(-)

And this piece:

    > -MODULE_VERSION("EHCA2_0035");
    > +MODULE_VERSION("EHCA2_0037");

indicates that there was a 0036 that you never let anyone see.

I would suggest you try to use the openib.org svn tree as your real
development repository.  This will be the way you will have to work
once your driver is in the upstream kernel, and even now you will get
benefit from getting better patch review and having users better able
to pin down when a regression might have been introduced.

For your latest checkin, it would have been better to see a series of
changesets with commit logs like:

    - remove asm_sync_mem() and mftb(), which duplicate existing
      definitions in include/asm-ppc64
    - make sure device is an eHCA in libehca's openib_driver_init()
    - update Kconfig help text

and so on...

Thanks,
  Roland