[openib-general] Re: [PATCH] mthca: fix posting long work request lists

Grant Grundler iod00d at hp.com
Wed Nov 9 14:40:55 PST 2005


On Wed, Nov 09, 2005 at 11:40:00PM +0200, Michael S. Tsirkin wrote:
> > I added SRQ support and also moved the doorbell[2]
> > declaration to the top of the functions (since I'm not convinved all
> > versions of gcc are smart enough to see that two copies of doorbell[]
> > can share stack slots).
> 
> True. AFAIK no existing gcc version is smart enough for this.

I thought gcc tracks register usage and not stack usage per se.
And I don't understand why we should worry about "stack slots"
given the "scope" of usage in each case is very short.

My preference is to always declare variables in the smallest
scope possible...it makes maintaining the code easier and lets
gcc make more efficient use of registers (ie don't allocate stack
at all if it can be done in registers).

thanks,
grant



More information about the general mailing list