[openib-general] [PATCH] netdevice.h: Add RDMA private pointer to the net_device structure

Pradeep Satyanarayana pradeep at us.ibm.com
Mon Oct 3 16:52:55 PDT 2005





Ok thanks for the explanation. So, I presume that means rdma_ptr will now
point to ib_device?

If so, one issue that strikes me as significant would be backward
compatability. My view is that one could continue to
use the IPoIB private data.

Pradeep
pradeep at us.ibm.com

Hal Rosenstock <halr at voltaire.com> wrote on 10/03/2005 04:17:17 PM:

> On Mon, 2005-10-03 at 19:05, Pradeep Satyanarayana wrote:
> > My understanding is that the refcnt will still need to be held (even
> > after this change) even if SDP would not poke at IPoIB's private data.
> > Is that true?
>
> Yes, that's an independent issue.
>
> > Moreover there was discussion about getting this data from the CM REQ
> > private data. So, what is the exact rationale for adding this to the
> > net_device structure?
>
> To get at the ib_device, port, and PKey which are needed for a
> subsequent SA path record request.
>
> -- Hal
>
> > Pradeep
> > pradeep at us.ibm.com
> >
> > openib-general-bounces at openib.org wrote on 10/03/2005 02:50:21 PM:
> >
> > > On Mon, 2005-10-03 at 17:35, Roland Dreier wrote:
> > > >     Hal> We will have this shortly. I have been waiting for this
> > to
> > > >     Hal> propose the changes to SDP et al.
> > > >
> > > > OK, but I don't think it makes sense to merge this upstream until
> > > > there is in-tree code that will use it.
> > >
> > > I wanted to get this in so I could add the code to IPoIB to use this
> > so SDP
> > > and others no longer poke at IPoIB's private data. This is a small
> > > change. Should this change be made locally (in OpenIB) first (and
> > we'll
> > > have our own modified netdevice.h for a short time) ?
> > >
> > > -- Hal
> > >
> > > _______________________________________________
> > > openib-general mailing list
> > > openib-general at openib.org
> > > http://openib.org/mailman/listinfo/openib-general
> > >
> > > To unsubscribe, please visit
> > http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20051003/1800603f/attachment.html>


More information about the general mailing list