[openib-general] Re: [PATCH] Opensm - handling immediate error in vendor_send new

Hal Rosenstock halr at voltaire.com
Tue Oct 11 05:42:37 PDT 2005


Hi Yael,

On Tue, 2005-10-11 at 04:28, Yael Kalka wrote:
> Attached is a new patch with several fixes for this issue.

Thanks. Applied.

There were still extra whitespace issues which I fixed by hand. Please
try to eliminate these so I don't have to do hand touch ups.

> I decided to remove the checking for zero in the atomic_dec after all,
> since as I mentioned before - clearing it is not a fix, and we will
> see the value in other infos in the log file.

But there is danger is these counters wrap, right ?

Also, in looking further at the code, the same issue does not appear to
occur for QP1 handling, right ?

-- Hal




More information about the general mailing list