[openib-general] Re: [PATCH] [MAD/Agent] convert agent.c to use ib_create_send_mad()

[Sean Hefty]

Hal Rosenstock wrote:
> I was referring to the calls in agent_send_response which could fail.

It may not be obvious by reading the patch, but agent_send_response() now 
consists of:

ib_get_agent_port()
ib_create_ah_from_wc()
ib_create_send_mad()
ib_post_send_mad()

The wc and grh params are only needed to create the AH, with cleanup handled by 
the completion callback.  Agent_send_response() no longer accesses anything from 
its parameters after the call returns.

> Yes. It can be done as a subsequent patch. I just think we want to know
> when those calls in agent_send_response do fail as they may explain some
> other external behavior (e.g. a lack of response by the SMA and/or PMA).

I'll add it to this one.  I'm guessing that we may to commit everything at once, 
after ib_post_send_mad() has been updated.

- Sean