[openib-general] Re: [PATCH] SDP: In sdp_link.c::do_link_path_lookup, handle interface table numbering holes

Hal Rosenstock halr at voltaire.com
Thu Oct 20 08:15:05 PDT 2005


On Thu, 2005-10-20 at 11:03, James Lentini wrote:
> On Tue, 11 Oct 2005, Michael S. Tsirkin wrote:
> 
> mst> I think this list scan needs some kind of protection.
> mst> The following is what I checked in. Does this needs to be updated
> mst> in other places as well?
> 
> I agree that SDP must also obtain the dev_base_lock.

I think this was directed at the patch I supplied. I mistakenly left
that out. I think the code Michael committed in sdp_link.c obtains the
dev_base_lock appropriately.

-- Hal

> The update to IBAT, on which the SDP patch was based, used the 
> dev_base_lock (svn diff -r 3317:3547 core/at.c). 
> 
> The dev_base list isn't searched in any other places.






More information about the general mailing list