[openib-general] Re: [PATCH] [SRP] support for it_iu length negotiation

[Roland Dreier]

Thanks for the patch.  However, I would like to hold off on new
features for the SRP driver to get it merged into 2.6.15.  There's
about another week in the 2.6.15 merge window, so either way the delay
shouldn't be too long.

With that said I don't think I like this patch.  I don't think it's a
win to allocate 1 KB IUs when we'll almost never have gather/scatter
lists that big.  Even the 256 byte IUs that the current driver uses
seem on the borderline of being too big.

Also, is it really a win to have the target fetch a large indirect
buffer list?  It seems like it would be better for performance to give
the SCSI layer a limit on the size of the gather/scatter list we
support so that our indirect buffer lists always fit in the IUs we send.

 - R.