[openib-general] Re: [PATCH} OpenSM: Add MGID to 1B11 error message

[Eitan Zahavi]

Good - we needed it long ago.

Hal Rosenstock wrote:
>>               cl_ntoh64(REQUIRED_MC_CREATE_COMP_MASK),
It is common practice to use CL_NTOH (upper case) for converting constants.
The claim in the cl_byteswap.h is that the upper case version of constants is handled
by the compiler and thus is faster to evaluate. I must say I have not verified that but
it seems logical to me.
Anyway the upper case version should never be used on anything that is not a constant!
>>               cl_ntoh64( p_recvd_mcmember_rec->mgid.unicast.prefix ),
>>               cl_ntoh64( p_recvd_mcmember_rec->mgid.unicast.interface_id ) );