[openib-general] Re: [PATCHv2] OpenSM: OpenIB vendor layer: Implement osm_vendor_delete

[Eitan Zahavi]

Hal Rosenstock wrote:
> On Tue, 2005-09-06 at 11:17, Eitan Zahavi wrote:
> 
>>Hal Rosenstock wrote:
>>
>>>On Tue, 2005-09-06 at 11:04, Eitan Zahavi wrote:
>>>
>>>
>>>>Hal Rosenstock wrote:
>>>>
>>>>
>>>>>[same patch just generated with diff -up]
>>>>>
>>>>>OpenSM: OpenIB vendor layer: Implement osm_vendor_delete
>>>>>
>>>>>[I've done some testing of this; are there any regressions for this ?]
>>>>
>>>>OpenSM call osm_vendor_delete during osm_opensm_destroy.
>>>>It is invoked during exit.
>>>
>>>
>>>Actually, it should have said "Implement osm_vendor_unbind" rather than
>>>delete.
>>
>>Well the semantics are very old. We stick to the old osm_vendor_api.h. Maybe we should not have.
>>But now we have too much depending on this API that I urge you not to modify it if possible.
> 
> 
> I didn't change the semantics. I implemented the OpenIB version. Recall
> that Yael had indicated this was needed when she started on the 1.8.0
> merge work.
I did not mean that. I thought you proposed to rename osm_opensm_destroy osm_vendor_unbind
but now I'm not sure this is what you meant. My comment was about renaming.
I think I have to go home... so I do not waste your time not being able to read right.

I'll probably login in 2 hours or so.
> 
> -- Hal