[openib-general] [PATCH] sdp: set default zcopy threshold by module parameter

Roland Dreier rolandd at cisco.com
Tue Sep 6 08:41:53 PDT 2005


    > +static int sdp_zcopy_thrsh_src_default = SDP_ZCOPY_THRSH_SRC_DEFAULT;
    > +module_param(sdp_zcopy_thrsh_src_default, int, 0666);
    > +MODULE_PARM_DESC(sdp_zcopy_thrsh_src_default, "Default ZCopy Threshold for Data Source");
    > +static int sdp_zcopy_thrsh_snk_default = SDP_ZCOPY_THRSH_SNK_DEFAULT;
    > +module_param(sdp_zcopy_thrsh_src_default, int, 0666);
    > +MODULE_PARM_DESC(sdp_zcopy_thrsh_snk_default, "Default ZCopy Threshold for Data Sink");

0666 seems like a strange choice of permissions here.  Would it be
better as 0644?

 - R.



More information about the general mailing list