[openib-general] RE: [PATCHv2] OpenSM: OpenIB vendor layer: Implement osm_vendor_d elete

[Hal Rosenstock]

Hi Yael,

On Sun, 2005-09-11 at 04:11, Yael Kalka wrote: 
> There is a problem with the patch.
> 1. In osm_vendor_unbind: You used free(p_bind), when the pointer was
> allocated using cl_zalloc.
>    You need to use cl_free.

OK.

> 2. There is a race between the cl_free and the receiver thread. We get
> a segmentation fault due to the fact that the thread isn't destroyed
> before freeing the p_bind object. There should be a way to signal the
> reciever thread to exit, and the unbind should wait for that thread to
> join.

How can I reproduce that seg fault ? I never saw that in my testing of
this.

I will issue an updated version of this patch when I fix these issues.
Thanks.

-- Hal