[openib-general] Re: [PATCH] add cq error events

[Roland Dreier]

    Michael> The following implements reporting error events in mthca.
    Michael> (I've renamed mthca_cq_event to mthca_cq_completion, for
    Michael> consistency with qp events).

Looks good, I've checked it in to svn.  To be a good kernel citizen
I'll wait for 2.6.15 to merge it upstream (since we're in bugfix-only
time right now).

    Michael> As a side note, the spec says: "Two types of CQ errors
    Michael> can occur: the CQ can overrun or it can become
    Michael> inaccessible": I wander whether this should be
    Michael> interpreted in a sense that that there should be two
    Michael> types of events: IB_EVENT_CQ_OVERRUN and
    Michael> IB_EVENT_CQ_ACCESS, rather than just a generic
    Michael> IB_EVENT_CQ_ERR

Yes, this seems useful to me.  The reason is that a CQ overrun
indicates a bug in the consumer, and a CQ access error indicates a bug
in the verbs implementation.  So it's useful to be able to tell whose
fault a CQ error is.

 - R.