[openib-general] Re: [PATCH] SDP: In do_link_path_lookup, make sure device is IPoIB hardware type

[Hal Rosenstock]

On Tue, 2005-09-27 at 07:35, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > Subject: [PATCH] SDP: In do_link_path_lookup, make sure device is IPoIB hardware type
> > 
> > In do_link_path_lookup, make sure device selected is IPoIB hardware
> > type before accessing its local private data
> 
> 
> Hal, does this fix some actual problem you are seeing?

Yes, I saw it with AT. It has the same exact code in terms of this.
Try an ethernet IP address as a destination and see what happens.

> sdp_link.c has
> 
>         if (rt->u.dst.neighbour->dev->type != ARPHRD_INFINIBAND &&
>             !(rt->u.dst.neighbour->dev->flags & IFF_LOOPBACK)) {
>                 result = -ENETUNREACH;
>                 goto error;
>         }
> 
> and this seems to check the device type.

but that's before the device might be changed.

-- Hal