[openib-general] Re: [O-MPI devel] [PATCH] Update Open MPI for new libibverbs API

[Brian Barrett]

On Sep 26, 2005, at 4:20 PM, Roland Dreier wrote:

> [It's somewhat annoying to have to subscribe to devel at open-mpi.org
> just to be able to send patches, but oh well...]

It's even more annoying to be deluged with SPAM ;).  We (the LAM  
developers) used to try to keep our mailing lists as open as  
possible.  In the end, SPAM pushed the signal to noise ratio way too  
high and something had to be done.  Requiring subscriptions to post  
was the best we could do.

> This patch updates Open MPI for the new ibv_create_cq() API.
> Signed-off-by: Roland Dreier <rolandd at cisco.com>

I'll admit my ignorance - is this part of a particular release of  
OpenIB, or is this something that has happened recently in SVN?  I  
ask because we already have people using OpenIB and Open MPI  
together, and it would be bad to suddenly break things for them.   
Testing for number of arguments in a function is horribly unreliable  
- is there some version number or other key in the Open IB headers we  
can use to determine which version of the function to use?

Brian


> --- ompi/mca/btl/openib/btl_openib.c    (revision 7507)
> +++ ompi/mca/btl/openib/btl_openib.c    (working copy)
> @@ -656,7 +656,8 @@ int mca_btl_openib_module_init(mca_btl_o
>      }
>
>      /* Create the low and high priority queue pairs */
> -    openib_btl->ib_cq_low = ibv_create_cq(ctx,  
> mca_btl_openib_component.ib_cq_size, NULL);
> +    openib_btl->ib_cq_low = ibv_create_cq(ctx,  
> mca_btl_openib_component.ib_cq_size,
> +                                  NULL, NULL, 0);
>
>      if(NULL == openib_btl->ib_cq_low) {
>          BTL_ERROR(("error creating low priority cq for %s errno  
> says %s\n",
> @@ -665,7 +666,8 @@ int mca_btl_openib_module_init(mca_btl_o
>          return OMPI_ERROR;
>      }
>
> -    openib_btl->ib_cq_high = ibv_create_cq(ctx,  
> mca_btl_openib_component.ib_cq_size, NULL);
> +    openib_btl->ib_cq_high = ibv_create_cq(ctx,  
> mca_btl_openib_component.ib_cq_size,
> +                                   NULL, NULL, 0);
>
>      if(NULL == openib_btl->ib_cq_high) {
>          BTL_ERROR(("error creating high priority cq for %s errno  
> says %s\n",
> _______________________________________________
> devel mailing list
> devel at open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>