[openib-general] Re: [PATCH] opensm: observe PartitionEnforcementCap of zero

[Hal Rosenstock]

On Wed, 2006-03-29 at 18:54, Rolf Manderscheid wrote:
> Hi Hal,
> 
> opensm attempts to set pkey table entries on external switch ports
> even if the switch declares a PartitionEnforcementCap of zero.  The
> consequence is ERR 4108.
> 
> The decision to set the block is based on the size of the
> pkeys->blocks vector, which is initialized to one.  There is a
> comment that claims there must be a pre-allocated block in said vector
> "for the sake of empty table test", but I can't see why it's
> necessary.  Is this comment wrong or am I missing something?
> 
> The vector size grows, if necessary, when processing the response from
> a SubnGet(PKeyTable).  The query happens during a sweep after
> obtaining the portinfo, and the query code is careful to observe the
> partition cap.  All this means that the vector size can still be used
> to decide whether to do the set provided the vector size starts out at
> zero.  So, the patch below just initializes the vector to size zero
> and removes the code that inserts the pre-allocated block.
> 
>     Rolf

Thanks. Applied.

-- Hal