[openib-general] RE: [PATCH] OpenSM/osm_sa_portinfo_record.c: Fix precedence in bitwisecompare of PortInfo capability mask

Eitan Zahavi eitan at mellanox.co.il
Mon Apr 3 06:32:45 PDT 2006


Oops - thanks for catching it
Eitan
> 
> OpenSM/osm_sa_portinfo_record.c: Fix precedence in bitwise compare of
> PortInfo capability mask
> 
> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> 
> Index: opensm/osm_sa_portinfo_record.c
> ===================================================================
> --- opensm/osm_sa_portinfo_record.c     (revision 6161)
> +++ opensm/osm_sa_portinfo_record.c     (working copy)
> @@ -294,7 +294,7 @@ __osm_sa_pir_check_physp(
>    {
>      if (p_ctxt->is_enhanced_comp_mask)
>      {
> -      if ( (p_comp_pi->capability_mask & p_pi->capability_mask !=
p_comp_pi-
> >capability_mask) )
> +      if ( ( ( p_comp_pi->capability_mask & p_pi->capability_mask )
!= p_comp_pi-
> >capability_mask) )
>          goto Exit;
>      }
>      else




More information about the general mailing list