[openib-general] RE: CMA and SDP hh

Sean Hefty sean.hefty at intel.com
Wed Apr 5 16:20:16 PDT 2006


>                *ip_ver = sdp_get_ip_ver(hdr);
>                *port   = ((struct sdp_hh *) hdr)->port;
>                *src    = &((struct sdp_hh *) hdr)->src_addr;
>                *dst    = &((struct sdp_hh *) hdr)->dst_addr;
>
>seems to assume that SDP places the HH message at the beginning
>of the private data in CM messages.
>
>However, I think in SDP HH is preceded by the BSDH, so this looks wrong.

Yes - you're correct.  I assumed that the HH was at the start of the private
data, but the BSDH should go there.  To fix this, I think we'll want to add bsdh
in struct sdp_hh in cma.c. 

struct sdp_hh {
	u8 bsdh[16];
	u8 sdp_version;
	u8 ip_version;	/* IP version: 7:4 */
	u8 sdp_specific1[10];
	__u16 port;
	__u16 sdp_specific2;
	union cma_ip_addr src_addr;
	union cma_ip_addr dst_addr;
};

- Sean



More information about the general mailing list