[openib-general] Re: Re: RE: Re: [PATCH] ipoib_flush_paths

[Michael S. Tsirkin]

Quoting r. Muli Ben-Yehuda <mulix at mulix.org>:
> Subject: Re: Re: RE: Re: [PATCH] ipoib_flush_paths
> 
> On Thu, Apr 06, 2006 at 05:04:07PM +0300, Michael S. Tsirkin wrote:
> 
> > struct query {
> > 	void (*callback)();
> > 	struct module *owner;
> > }
> > 
> > Then it is always safe to do
> > 
> > 	__get_module(query->owner);
> > 	query->callback();
> > 	put_module(query->owner);
> 
> Ok, that makes sense. By the way, shouldn't __get_module be
> try_module_get(), with proper error handling if it fails?

No, the whole point is it can't fail.
If it fails its a bug - there's nothing I can do.

-- 
MST