[openib-general] Re: RE: Re: [PATCH] ipoib_flush_paths

[Michael S. Tsirkin]

Quoting r. Fabian Tillier <ftillier at silverstorm.com>:
> Subject: Re: RE: Re: [PATCH] ipoib_flush_paths
> 
> On 4/5/06, Sean Hefty <sean.hefty at intel.com> wrote:
> > >Can't you pass in a reference to the client module for registration,
> > >and then take a reference from the context of each request that is
> > >released after the callback unwinds?  I thought Linux had module
> > >reference functions...
> >
> > Yes - this is what ib_mad does.  The problem is that ib_sa, ib_addr, ib_cm, and
> > soon to be ib_multicast can invoke callbacks without explicit registration /
> > deregistration.  For example, the following interface has the issue:
> >
> > ib_do_async_operation(request, my_callback, my_context);

Correct, that's the issue. So this means we can't fix it without
some kind of API change.

> You don't need explicit registration/deregistration - just add a
> module parameter to this function:
> 
> ib_do_async_op_safe( my_module, request, my_callback, my_context );

That's what I did - added owner parameter after callback and context.

-- 
MST