[openib-general] Re: [RFC] [PATCH 1/2] multicast support formultiple users

[Suresh Shelvapille]

Sean/Roland:

I may be the only one using the openib stack for a switch. I don't need the
module in question at this point, but I request the group to consider
putting all changes for a switch (as well) while adding new functionality. 

This way, if and when I get to a point of needing the functionality, I would
have something to start with! And I promise to test and send in changes (if
required).

BTW, as far as the ib_mad/smi stuff goes, I have sent my changes to Hal,
since I am running 2.6.12 and it is best if he does the merge (I think he
said so already in his email).

Thanks a lot,
Suri


> -----Original Message-----
> From: openib-general-bounces at openib.org [mailto:openib-general-
> bounces at openib.org] On Behalf Of Sean Hefty
> Sent: Thursday, April 06, 2006 4:17 PM
> To: Roland Dreier
> Cc: openib-general at openib.org
> Subject: Re: [openib-general] Re: [RFC] [PATCH 1/2] multicast support
> formultiple users
> 
> Roland Dreier wrote:
> >  > +	dev = kmalloc(sizeof *dev + device->phys_port_cnt * sizeof
> *port,
> >  > +		      GFP_KERNEL);
> >  > +	if (!dev)
> >  > +		return;
> >  > +
> >  > +	for (i = 1; i <= device->phys_port_cnt; i++) {
> >
> > Seems like this is implicitly assuming that the IB device is a CA.
> >
> > Maybe we should give up the ghost and stop trying to support IB
> switches?
> 
> I can go either way here.  Would someone want to use this module on a
> switch?
> If so, I can fix up the code so that it can work on one, or at least
> change the
> checks that the device is a CA.
> 
> I thought that someone was running at least ib_mad on a switch.  I'm just
> not
> sure which other modules are likely to run on them.
> 
> - Sean
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-
> general